fix(memory): pass embedding store to EntityResolver in extract_and_store#1827
Merged
fix(memory): pass embedding store to EntityResolver in extract_and_store#1827
Conversation
EntityResolver was constructed without with_embedding_store() in the production extract_and_store path, so store_entity_embedding() was never called. As a result zeph_graph_entities stayed empty and link_memory_notes found no similar entities, silently producing zero similar_to edges. Thread the optional Arc<EmbeddingStore> from spawn_graph_extraction into extract_and_store and wire it into EntityResolver construction, matching the pattern already used in test helpers. Call sites that have no embedding store (graph backfill in graph_commands, unit tests) pass None. Closes #1817
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntityResolverin the productionextract_and_storepath was constructed without.with_embedding_store(), sostore_entity_embedding()was never called —zeph_graph_entitiesstayed empty andlink_memory_notesfound no candidates, silently producing zerosimilar_toedgesArc<EmbeddingStore>fromspawn_graph_extractionintoextract_and_storeand wire it intoEntityResolverconstruction, matching the pattern already used in test helpersgraph_commands, unit tests) passNoneCloses #1817
Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— zero warningscargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5790 passed