fix(policy): accept "shell"/"sh" as aliases for "bash" tool_id in policy rules#1891
Merged
fix(policy): accept "shell"/"sh" as aliases for "bash" tool_id in policy rules#1891
Conversation
…icy rules ShellExecutor registers itself as tool_id="bash" but users intuitively write `tool = "shell"` in policy rules, causing silent mismatches. Add resolve_tool_alias() in policy.rs and apply it in both compile() (for rule tool field) and evaluate() (for runtime tool_name), so any combination of "bash"/"shell"/"sh" works correctly in both directions. Closes #1877
github-actions
bot
added
bug
bug-ops
added a commit
that referenced
this pull request
Mar 15, 2026
Both test sections coexist: symlink boundary check (this PR) and tool alias resolution (main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellExecutorregisters astool_id="bash"but users intuitively writetool = "shell"in policy rules, causing silent mismatches — security-critical whendefault_effect = "allow"resolve_tool_alias()inpolicy.rsmapping"bash"/"sh"→"shell"PolicyEnforcer::compile()(ruletoolfield) andevaluate()(runtimetool_name) so any combination of names works in both directionsTest plan
alias_shell_rule_matches_bash_tool_id— core bug:tool="shell"rule matchestool_id="bash"alias_bash_rule_matches_bash_tool_id— regression:tool="bash"still worksalias_sh_rule_matches_bash_tool_id—tool="sh"also matchestool_id="bash"alias_unknown_tool_unaffected— unknown tools pass through unchanged--features full)Closes #1877