fix(core): wire Focus Agent and SideQuest config from TOML to agent builder#1914
Merged
fix(core): wire Focus Agent and SideQuest config from TOML to agent builder#1914
Conversation
github-actions
bot
added
documentation
…otstrap paths AgentBuilder::with_focus_config() and AgentBuilder::with_sidequest_config() were never called from bootstrap, so [agent.focus] and [memory.sidequest] config sections were silently ignored (always defaulting to enabled=false). Wire both calls in runner.rs, daemon.rs, and acp.rs (SharedAgentDeps gains focus_config and sidequest_config fields). Closes #1907
bug-ops
force-pushed
the
1907-fix-core-focus-agent-and-sideq
branch
from
e8c4edc to
aaf1b7c
Compare
bug-ops
added a commit
that referenced
this pull request
Mar 16, 2026
…otstrap paths (#1914) AgentBuilder::with_focus_config() and AgentBuilder::with_sidequest_config() were never called from bootstrap, so [agent.focus] and [memory.sidequest] config sections were silently ignored (always defaulting to enabled=false). Wire both calls in runner.rs, daemon.rs, and acp.rs (SharedAgentDeps gains focus_config and sidequest_config fields). Closes #1907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1907.
Root Cause
AgentBuilder::with_focus_config()andAgentBuilder::with_sidequest_config()were defined but never called from any bootstrap path. All bootstrap entry points constructedAgentBuilderwithout passingconfig.agent.focusorconfig.memory.sidequest, so both subsystems always ran with defaults (enabled = false).Changes
src/runner.rs: chain.with_focus_config()and.with_sidequest_config()when building the agentsrc/daemon.rs: same wiring for daemon pathsrc/acp.rs: addfocus_configandsidequest_configtoSharedAgentDeps, populated from config at init, applied inspawn_acp_agentcrates/zeph-core/src/agent/builder.rs: add two unit tests verifying config propagation toFocusStateandSidequestStateCHANGELOG.md: fix entry under[Unreleased]Test Plan
cargo +nightly fmt --check— passcargo clippy --workspace --features full -- -D warnings— pass (0 warnings)cargo nextest run --workspace --features full --lib --bins— 6045 passed, 0 failedwith_focus_config_propagates_to_focus_state,with_sidequest_config_propagates_to_sidequest_state