fix(vault): replace blocking_read with block_in_place in ArcAgeVaultProvider#1940
Merged
fix(vault): replace blocking_read with block_in_place in ArcAgeVaultProvider#1940
Conversation
…rovider blocking_read() panics when called from within a tokio async context. list_keys() is a sync trait method called inside async resolve_secrets(), so use block_in_place to signal to the runtime that the thread will block.
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArcAgeVaultProvider::list_keys()calledblocking_read()on atokio::sync::RwLock, which panics when invoked from within an async runtimelist_keys()is a synchronous trait method called insideasync fn resolve_secrets(), making the panic reproducible on every TUI startup withvault.backend = "age"blocking_read()withtokio::task::block_in_place(|| arc.blocking_read())so tokio can reschedule other tasks while the thread is heldTest plan
cargo +nightly fmt --check— passedcargo clippy --workspace --features full -- -D warnings— passedcargo nextest run --workspace --features full --lib --bins— 6117 passedzeph --config .local/config/cloud.toml --tui— no longer panics at startup