refactor(memory): wrap cleanup() in atomic transaction#2041
Merged
Conversation
github-actions
bot
added
documentation
Both DELETE (expired rows) and UPDATE (stale embeddings) in ResponseCache::cleanup() now run inside a single SQLite transaction. On error, the transaction is automatically rolled back, preventing partial cleanup state. Closes #2032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ResponseCache::cleanup() executed two SQL operations independently.
A failure between them left partial state: expired rows deleted but
stale embeddings still present, or vice versa.
Solution
Wrap both operations in a single SQLite transaction via pool.begin() /
tx.commit(). On error, sqlx automatically rolls back for all-or-nothing semantics.
Tests
6014/6014 pass. No new test needed — atomicity is enforced by SQLite.
Closes #2032