Conversation
…ure (#2067) The test module subgoal_extraction_tests at line 3520 in crates/zeph-core/src/agent/context/summarization.rs calls parse_subgoal_extraction_response() which is gated with #[cfg(feature = "context-compression")]. However, the test module itself was missing this feature gate, causing E0425 (cannot find function) when running cargo nextest without --features full. Added #[cfg(feature = "context-compression")] attribute to the subgoal_extraction_tests module definition. Fixes: #2067
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test module
subgoal_extraction_testsat line 3520 incrates/zeph-core/src/agent/context/summarization.rscallsparse_subgoal_extraction_response()which is gated with#[cfg(feature = "context-compression")]. However, the test module itself was missing this feature gate, causing E0425 (cannot find function) when runningcargo nextestwithout--features full.Changes
#[cfg(feature = "context-compression")]attribute to thesubgoal_extraction_testsmoduleTesting
--features full: 5711 tests passed--features full: 6241 tests passedPre-merge Checklist
cargo +nightly fmt --checkpassedcargo clippy --workspace -- -D warningspassedcargo nextest run --workspace --lib --binspassed (both with and without --features full)Closes #2067