fix(memory): align MAGMA entity extraction prompt with EntityType enum#2083
Merged
fix(memory): align MAGMA entity extraction prompt with EntityType enum#2083
Conversation
#2079) Replace `technology` with `tool` and `language` as separate entity types in the graph extraction prompt. This matches the actual EntityType enum variants and eliminates the "unknown entity type, falling back to Concept" resolver warnings that occurred for programming languages and frameworks.
3efa481 to
903a7c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2079
Summary
EntityTypeRust enumtechnologywith two distinct types:tool(frameworks, libraries, software tools) andlanguage(programming and natural languages)types.rsorresolver/mod.rs—FromStr/Displayalready covered all variants and the fallback log was already clearTest plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleancargo nextest run --workspace --features full --lib --bins— 6323/6323 passed