fix(sidequest): handle ToolResult in rebuild_cursors and apply_eviction#2120
Merged
fix(sidequest): handle ToolResult in rebuild_cursors and apply_eviction#2120
Conversation
…on (#2114) Native tool-use providers (OpenAI, Claude) store tool results as MessagePart::ToolResult, not MessagePart::ToolOutput. rebuild_cursors only matched ToolOutput, causing the cursor list to always be empty and eviction to silently do nothing on all native providers. Both rebuild_cursors and apply_eviction now match both variants. ToolResult uses a content sentinel "[evicted by sidequest]" for idempotency since the variant has no compacted_at field.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SidequestState::rebuild_cursorsandapply_evictionpreviously only matchedMessagePart::ToolOutput, silently skipping all tool results from native providers (OpenAI, Claude) which store results asMessagePart::ToolResultToolResultuses a content sentinel"[evicted by sidequest]"for idempotency (nocompacted_atfield on this variant)rebuild_cursors_includes_tool_resultandapply_eviction_handles_tool_resultFixes #2114.
Test plan
cargo nextest run -p zeph-core --lib— 6368 tests pass (+2 new)cargo clippy --workspace --features full -- -D warnings— cleanrebuild_cursors_includes_tool_result— ToolResult appears in cursor listapply_eviction_handles_tool_result— ToolResult content replaced with sentinel