Conversation
Add new MetricsSnapshot fields: stt_model, compaction_model, provider_temperature, provider_top_p, active_channel, embedding_model, token_budget, self_learning_enabled, semantic_cache_enabled. Populate startup fields in runner.rs from config (stt_model, compaction_model, embedding_model, semantic_cache_enabled, self_learning_enabled, active_channel). Update metrics on /provider switch (provider_name, model_name, temperature, top_p via Candle config). TUI status bar: show model name and ch:<channel> segments when set. Resources panel: render Embed:, Budget:, and Learning: ON lines conditionally. Tests: 7 new unit tests in metrics.rs, status.rs, resources.rs. Total: 6464 passed (was 6457).
Populate m.token_budget from budget_tokens in runner.rs send_modify block. Add [Unreleased] ### Added entry in CHANGELOG for Phase 2 metrics. Note: vault_backend, compaction_threshold, autosave_enabled were never present in MetricsSnapshot — their absence is not a regression.
github-actions
bot
added
documentation
…after merge After merging origin/main, the channel_segment was missing from the render() format string in status.rs; add it back so ch:<channel> appears in the status bar. Fix Phase 2 unit tests in resources.rs that used height=10 (collapsed mode) for assertions that require the expanded layout (height >= 30).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2160
Summary
MetricsSnapshot:stt_model,compaction_model,provider_temperature,provider_top_p,active_channel,embedding_model,token_budget,self_learning_enabled,semantic_cache_enabledrunner.rswith explicitAnyChannelvariant foractive_channeldetection/providerswitch to populateprovider_temperatureandprovider_top_pat runtimeTest plan
cargo +nightly fmt --check— cleancargo clippy --all-targets --all-features --workspace -- -D warnings— cleancargo nextest run --workspace --all-features --lib --bins— 6464/6464 passed