Conversation
…on async span re-entry ExtensionsMut::insert panics when the extension slot is already occupied. For async spans, on_enter fires on every poll cycle, so a SpanEntry from a prior enter is still present when the span re-enters during its destructor (e.g. drop of Instrumented<OpenAiProvider::chat::closure> in the memory tier promotion loop). Switching to replace silently overwrites the existing value, which is the correct semantic for tracking the most recent enter time.
github-actions
Bot
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtensionsMut::insertin tracing-subscriber panics if the extension slot is already occupied (assertionself.replace(val).is_none())on_enterfires on every poll cycle — aSpanEntryfrom a prior enter is still present when the span re-enters during its destructor (observed withInstrumented<OpenAiProvider::chat::closure>in the memory tier promotion loop)insert→replaceinmetrics_bridge.rs:on_enter;replaceoverwrites without panicking, which is the correct semantic for tracking the most recent enter timestampTest plan
cargo +nightly fmt --check— passedcargo clippy --workspace -- -D warnings— passedcargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 7842 tests passedcargo run --features full -- --tui --config .local/config/testing.tomlno longer aborts withpanic in a destructor during cleanup