fix(index): wrap chunk_file in spawn_blocking to unblock tokio runtime#2964
Merged
fix(index): wrap chunk_file in spawn_blocking to unblock tokio runtime#2964
Conversation
CPU-intensive tree-sitter AST parsing in chunk_file() was called directly inside async index_file(), blocking tokio workers and causing ~1000% CPU with buffer_unordered(2) during startup indexing. Wrap the call in tokio::task::spawn_blocking with JoinError mapped to IndexError::Other. Add async unit test covering the spawn_blocking dispatch and dedup idempotency path. Closes #2954
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chunk_file()(tree-sitter AST parsing) was called synchronously insideasync fn index_file(), blocking tokio workers and causing ~1000% CPU withbuffer_unordered(2)during startup indexingtokio::task::spawn_blocking;JoinErroris mapped toIndexError::Otherindex_file_spawn_blocking_dedup_pathcovering the spawn_blocking dispatch and dedup idempotency path (no Qdrant required)Test plan
cargo nextest run -p zeph-index— 103/103 passcargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— cleanCloses #2954