fix(plugins): rename plugin_dir to entry_dir in overlay.rs test helper#3157
Merged
fix(plugins): rename plugin_dir to entry_dir in overlay.rs test helper#3157
Conversation
github-actions
Bot
added
rust
…test helper Resolves clippy::similar_names violation between function parameter `plugins_dir` and local binding `plugin_dir` in the test module of overlay.rs. Renamed the local to `entry_dir` which is semantically clear and passes --all-targets clippy gate. Closes #3156
bug-ops
force-pushed
the
3156-clippy-similar-names-overlay
branch
from
da12dcd to
a638917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin_dirtoentry_dirin thewrite_plugin_overlaytest helper (crates/zeph-plugins/src/overlay.rs:348)clippy::similar_namesviolation between the parameterplugins_dirand the local bindingplugin_dircargo clippy --all-targets --workspace --features full -- -D warningsgateTest plan
cargo clippy -p zeph-plugins --all-targets -- -D warningspasses with zero warningscargo +nightly fmt --checkpassescargo nextest run --workspace --lib --bins— 8322 tests passCloses #3156