Conversation
github-actions
Bot
added
rust
… [quality] section Add two missing integration points for the MARCH self-check quality pipeline: - migrate_quality_config (zeph-config/src/migrate.rs): step 22 appends a commented-out [quality] block to configs that lack it. Uses line-anchored idempotency check and direct string append (no DocumentMut round-trip). - step_quality (src/init/mod.rs): --init wizard step prompting for self_check, trigger (Select from TriggerPolicy variants), and latency_budget_ms with validator [2000, 60000]. Informs users when self_check=true that proposer_provider/checker_provider are also required. - Re-export QualityConfig and TriggerPolicy from zeph-core/src/config.rs. Closes #3228
bug-ops
force-pushed
the
quality-migrate-config-init
branch
from
0fe21bb to
e26f991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3228.
PR #3226 added the MARCH self-check quality pipeline but two integration points were missing. This PR adds them:
migrate_quality_config(crates/zeph-config/src/migrate.rs): migration step 22 that appends a commented-out[quality]block to configs that lack it. Line-anchored idempotency check (no false-positives on[quality.foo]subtables). Direct string append — noDocumentMutround-trip that would reformat user config.step_quality()(src/init/mod.rs):--initwizard step prompting forself_check(Confirm),trigger(Select:has_retrieval/always/manual), andlatency_budget_ms(Input, validated[2000, 60000]). Whenself_check=true, prints an info note thatproposer_providerandchecker_providermust also be configured.QualityConfigandTriggerPolicyfromzeph-core/src/config.rs.Test plan
cargo nextest run -p zeph-config -E 'test(migrate_quality)'— 3/3 pass (absent, commented, active)cargo nextest run -p zeph -E 'test(build_config_quality)'— 4/4 pass (all 3 TriggerPolicy variants + defaults)cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— cleancargo nextest run --workspace --lib --bins— 8413/8413 pass