Conversation
github-actions
Bot
added
documentation
…to changed_count/sections_changed The fields were originally named for additions only, but after #3251 they also track removals. Rename to reflect the actual semantics. BREAKING CHANGE: MigrationResult::added_count renamed to changed_count; MigrationResult::sections_added renamed to sections_changed. Closes #3282
bug-ops
force-pushed
the
rename-migrationresult-added
branch
from
370f25e to
dde4d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MigrationResult::added_count→changed_countacross 6 filesMigrationResult::sections_added→sections_changedacross 6 files[Unreleased]CHANGELOG entryMotivation
After #3251,
migrate_compression_predictor_configusedadded_count: 1to report a removal, making the field name semantically inverted. The rename aligns the field names with their actual behavior (tracking any config change, not only additions).Test plan
rg 'added_count|sections_added' --type rust→ 0 hitscargo +nightly fmt --check→ passcargo clippy --workspace -- -D warnings→ cleancargo nextest run --workspace --lib --bins→ 8222 passed, 0 failedCloses #3282