fix(acp): use http_bind config field when autostarting HTTP server#3291
Merged
fix(acp): use http_bind config field when autostarting HTTP server#3291
Conversation
github-actions
Bot
added
bug
Previously run_acp_http_server always fell back to the hardcoded default 127.0.0.1:9800 when bind_override was None. The autostart path (AcpTransport::Http / Both) never passed the CLI override, so acp.http_bind from config was silently ignored. Now falls back to app.config().acp.http_bind, which carries the serde default (127.0.0.1:9800) when not set in config, preserving existing behaviour. Closes #3290
bug-ops
force-pushed
the
fix/3290-acp-http-bind-ignored
branch
from
5727747 to
8354bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_acp_http_servernow falls back toapp.config().acp.http_bindinstead of the hardcoded literal"127.0.0.1:9800"when no CLIbind_overrideis providedAcpTransport::Http/AcpTransport::Both) now respects[acp] http_bindfrom confighttp_bindis"127.0.0.1:9800", so configs without the field continue to work unchangedTest plan
cargo nextest run --workspace --lib --bins)[acp] transport = "http"+http_bind = "127.0.0.1:9811"in config, run agent, verifycurl http://127.0.0.1:9811/health→ 200 OK--acp-http-bindoverride still takes precedence over config fieldCloses #3290