feat(skills,memory): skill evaluator, proactive exploration, compression spectrum#3350
Merged
feat(skills,memory): skill evaluator, proactive exploration, compression spectrum#3350
Conversation
…compression spectrum Feature B (#3319): SkillEvaluator — external critic LLM scores generated skills on correctness/reusability/specificity before writing to disk. Weights and threshold are configurable; defaults to fail-open on evaluator error. Gate wired into SkillGenerator::approve_and_save and shared by proactive/promotion paths. Feature C (#3320): ProactiveExplorer — classifies query domain (keyword-based) and generates a world-knowledge-{domain} SKILL.md when none exists. Runs before context assembly; new skill visible from the next turn (intentional MVP bound to keep turn latency predictable). Feature A (#3305): CompressionLevel enum (Episodic/Procedural/Declarative), RetrievalPolicy that skips episodic recall below configurable token-budget thresholds, and PromotionEngine that scans episodic memory in a background JoinSet and promotes repeated patterns to skills. MemoryError::Promotion variant added; anyhow replaced with thiserror throughout new library code. All three features are disabled by default ([skills.evaluation], [skills.proactive_exploration], [memory.compression_spectrum]) and require no migration for existing configs. Closes #3319, #3320, #3305
This was
linked to
issues
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillEvaluator: external critic LLM scores generated skills on correctness/reusability/specificity before disk write. Configurable weights/threshold; fail-open by default. Wired into all skill-producing paths (generator, proactive explorer, promotion engine).ProactiveExplorer: classifies query domain (keyword-based) and generates aworld-knowledge-{domain}SKILL.md when none exists. Runs before context assembly; new skill visible from the next turn (intentional MVP bound).CompressionLevel+RetrievalPolicy+PromotionEngine: budget-aware retrieval granularity and background episodic→skill promotion.All three features are disabled by default (
enabled = false); existing configs parse unchanged (#[serde(default)]on every new field).Architecture
crates/zeph-skills/src/evaluator.rs—SkillEvaluator,SkillQualityScore,SkillVerdictcrates/zeph-skills/src/proactive.rs—ProactiveExplorer,DomainLabelcrates/zeph-memory/src/compression/mod.rs—CompressionLevel,RetrievalPolicycrates/zeph-memory/src/compression/promotion.rs—PromotionEngine,PromotionInputcrates/zeph-config/src/features.rs—SkillEvaluationConfig,ProactiveExplorationConfig,CompressionSpectrumConfigTest plan
cargo nextest run --workspace --lib --bins— 8326 tests passcargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— clean.local/testing/playbooks/skills-compression.mdskill-eval,proactive-explore,compression-spectrum(status: Untested)Notable design decisions
.await; next-turn rebuild is triggered bymatcher_dirtyflag.fail_open_on_error = falsefor strict enforcement.PromotionEngine::scantakesPromotionInput(notMemoryMatch) becauseMemoryMatchlacks session_id required for themin_sessionsheuristic.MemoryError::Promotionwiththiserror— noanyhowin library crates.Closes #3319, #3320, #3305