fix(builder): remove duplicate with_graph_config call in runner and daemon#3354
Merged
fix(builder): remove duplicate with_graph_config call in runner and daemon#3354
Conversation
…aemon apply_session_config already invokes apply_graph_config internally, so the subsequent with_graph_config call in the builder chain was redundant. This caused the PII redaction WARN to fire twice and RpeRouter to be initialized twice on every startup when memory.graph.enabled = true. Remove the redundant with_graph_config call from runner.rs and daemon.rs. Update the stale bare_flag test doc-comment that referenced the removed guard. Fixes #3351
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_session_configalready callsapply_graph_configinternally (builder.rs:1724), so the subsequentwith_graph_configcall inrunner.rsanddaemon.rswas redundantRpeRouterto be initialized twice on every startup whenmemory.graph.enabled = truewith_graph_configcall from both files; updated a stale test doc-comment that referenced the removed guardTest plan
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— cleancargo nextest run --workspace --lib --bins— 8328 passed, 0 failed[memory.graph] enabled = trueand confirm WARN appears exactly once in startup logFixes #3351