fix(config): document missing timeout tunables in default.toml#3381
Merged
fix(config): document missing timeout tunables in default.toml#3381
Conversation
Add llm_request_timeout_secs (600 s), context_prep_timeout_secs (30 s), and no_providers_backoff_secs (2 s) to the [timeouts] section with descriptive comments. These fields were added in #3373 but omitted from the reference config, making them invisible to migrate-config --diff and to users reading the config file. Closes #3377
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_request_timeout_secs,context_prep_timeout_secs, andno_providers_backoff_secsto[timeouts]inconfig/default.tomlwith descriptive commentsmigrate-config --diffand undiscoverable without reading source codeTest plan
cargo +nightly fmt --checkpassescargo clippy --workspace -- -D warningspassescargo nextest run --workspace --lib --bins— 8416 passed, 0 failedzeph migrate-config --diffwill now include all three fields for configs missing[timeouts]Closes #3377