Skip to content

fix(bench): enable zeph-llm testing feature for zeph-bench dev-dependencies#3404

Merged
bug-ops merged 1 commit intomainfrom
bench-fix
Apr 25, 2026
Merged

fix(bench): enable zeph-llm testing feature for zeph-bench dev-dependencies#3404
bug-ops merged 1 commit intomainfrom
bench-fix

Conversation

@bug-ops
Copy link
Copy Markdown
Owner

@bug-ops bug-ops commented Apr 25, 2026

Summary

  • AnyProvider::Mock in zeph-llm is gated behind cfg(any(test, feature = "testing")). The cfg(test) flag is not transitive across crates, so cargo test -p zeph-bench failed with 6 compilation errors in deterministic.rs.
  • Fix: add zeph-llm = { workspace = true, features = ["testing"] } to [dev-dependencies] in crates/zeph-bench/Cargo.toml.
  • All 91 zeph-bench unit tests now pass.

Benchmark run results (2026-04-25)

All criterion benchmarks verified working — results saved to .local/testing/bench-results-2026-04-25.md.

Crate Bench Status
zeph-skills cosine_similarity, cosine_ranking OK
zeph-memory token_estimation OK
zeph-core context_building OK
zeph-channels markdown_performance OK
zeph-llm classifier (--features classifiers) OK

Test plan

  • cargo test -p zeph-bench --lib passes (91 tests)
  • cargo bench -p zeph-skills runs without errors
  • cargo bench -p zeph-memory runs without errors

AnyProvider::Mock is gated behind cfg(any(test, feature = "testing"))
in zeph-llm. cfg(test) does not propagate transitively, so deterministic.rs
tests failed to compile when building zeph-bench tests.

Adding zeph-llm with features=["testing"] to [dev-dependencies] makes the
Mock variant available during test compilation without affecting the
production build.
@github-actions github-actions Bot added dependencies Dependency updates bug Something isn't working size/XS Extra small PR (1-10 lines) labels Apr 25, 2026
@bug-ops bug-ops enabled auto-merge (squash) April 25, 2026 18:59
@bug-ops bug-ops merged commit cf6b95f into main Apr 25, 2026
32 checks passed
@bug-ops bug-ops deleted the bench-fix branch April 25, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Dependency updates size/XS Extra small PR (1-10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant