refactor: decompose long functions in zeph-mcp, zeph-index, zeph-subagent#3469
Merged
refactor: decompose long functions in zeph-mcp, zeph-index, zeph-subagent#3469
Conversation
github-actions
Bot
added
documentation
This was
linked to
issues
Apr 26, 2026
bug-ops
force-pushed
the
decompose-long-funcs-multi
branch
from
eb8c335 to
afc8222
Compare
bug-ops
force-pushed
the
decompose-long-funcs-multi
branch
from
afc8222 to
deaef25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect_all,connect_oauth_deferred,add_serverinzeph-mcp/src/manager.rsinto focused private helpersindex_projectinzeph-index/src/indexer.rsintoensure_collection_for_provider,walk_project_files,index_batch,cleanup_removed_filesrun_agent_loopinzeph-subagent/src/agent_loop.rsintobuild_effective_system_prompt,call_provider_with_status,emit_working_status,handle_secret_request,handle_no_tool_response,init_loop_state,run_turnwithTurnOutcome/NoToolAction/SecretRequestOutcomeenums for explicit control flow#[allow(clippy::too_many_lines)]suppressions from the target functionsPure refactoring — no behavior changes, no public API changes, no new dependencies.
Test plan
cargo clippy --workspace -- -D warnings— cleancargo nextest run --workspace --lib --bins— 8605 passed, 0 failedcargo +nightly fmt --check— cleanCloses #3451, #3458, #3447