Conversation
…lag; skip embed-only fallback in provider pool Remove the spurious `test` arm from the cfg gate on the `EnvVaultProvider` re-export in zeph-core/src/lib.rs. The arm caused cargo to include the re-export during test builds even when the `env-vault` feature was not activated, breaking plain `cargo nextest run -p zeph-core`. Closes #3485. In `build_single_provider_from_pool`, add an `or_else` fallback that skips embed-only entries when no provider carries `default = true`, mirroring the existing guard in `build_all_pool_providers`. Closes #3484.
github-actions
Bot
added
documentation
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testarm from#[cfg(any(test, feature = "env-vault"))]gate onEnvVaultProviderre-export inzeph-core/src/lib.rs. The arm caused test builds to include the re-export even whenzeph-vault/env-vaultwas not activated, makingcargo nextest run -p zeph-corefail without explicit--features env-vault.build_single_provider_from_pool, add anor_elsefallback that skips embed-only entries when no provider hasdefault = true, preventing an embed model from silently being used for chat. Mirrors the existing guard inbuild_all_pool_providers.Test plan
cargo nextest run -p zeph-core(no--features) — 1508/1508 passcargo nextest run --workspace --lib --bins— 8623/8623 passcargo +nightly fmt --check— cleancargo clippy(CI feature scope) — 0 warningsCloses #3485
Closes #3484