refactor(core): extract zeph-agent-feedback from zeph-core (Phase 1, PR 0b)#3494
Merged
refactor(core): extract zeph-agent-feedback from zeph-core (Phase 1, PR 0b)#3494
Conversation
f5f1701 to
efbe29c
Compare
Move FeedbackDetector and JudgeDetector (1933 LoC) out of crates/zeph-core/src/agent/feedback_detector.rs into a new focused crate crates/zeph-agent-feedback/. This is the only file in zeph-core with zero Agent<C> coupling today, making extraction clean without circular dependencies. Creates the first real compile boundary: changes to feedback detection no longer trigger a full zeph-core rebuild. All call sites updated to use zeph_agent_feedback:: directly; no compatibility aliases retained. All 8623 workspace tests pass. Part of the Phase 1 decomposition plan for issue #3480.
efbe29c to
1c222de
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts
FeedbackDetectorandJudgeDetector(1,933 LoC) fromcrates/zeph-core/src/agent/feedback_detector.rsinto a new focused cratecrates/zeph-agent-feedback/.This is the first deliverable of the Phase 1 decomposition plan for #3480. It is the only file in
zeph-corewith zeroAgent<C>coupling today, making clean extraction feasible without circular dependencies.What changed
crates/zeph-agent-feedback/withFeedbackDetector,JudgeDetector, and all associated typescrates/zeph-core/src/agent/feedback_detector.rsremoved; all 5 call sites updated to usezeph_agent_feedback::directlyWhy this matters
zeph-corerebuildzeph-coreby 1,933 LoC (2.4% of total)Agent<C>god-object decomposition unblocks)Scope of Phase 1 vs issue acceptance criteria
Per the architecture investigation:
zeph-coreto ~40K production LoC — the 30K target requires Phase 2 (new tracking issue to be filed)Test plan
cargo build --workspace— cleancargo clippy --workspace -- -D warnings— zero warningscargo +nightly fmt --check— cleancargo nextest run --workspace --lib --bins— 8,623 tests passzeph-agent-feedbackcover all public APIs (FeedbackDetector, JudgeDetector, CorrectionKind, JudgeVerdict)Closes #3480