fix(memory,context,eviction): resolve critical TODOs#3534
Merged
Conversation
…t cleanup, proactive compression guidelines, dead stub removal - Remove unimplemented!() stub ContextService::rebuild_system_prompt (dead code, zero callers; real impl lives on Agent<C>) - Fix proactive compression path to load and pass compression_guidelines via load_compression_guidelines_for_compact() before constructing ContextSummarizationView; closes #3533 - Wire Qdrant vector deletion in eviction phase 2: start_eviction_loop now accepts Option<Arc<EmbeddingStore>>; run_eviction_phase2 calls delete_by_message_ids before mark_qdrant_cleaned (crash-safe order); runner.rs threads embedding store through - Add EmbeddingStore::delete_by_message_ids with supporting tests - Replace stale TODO comment in SubagentManager::spawn_subagent with accurate map of three existing permission-enforcement sites - Add compression_guidelines_flow_through_proactive_compress_path test verifying the full SQLite → load → view → LLM-prompt data-flow for issue #3533
github-actions
Bot
added
documentation
…to fix clippy::doc_markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unimplemented!()stub —ContextService::rebuild_system_prompthad zero callers and panicked unconditionally; deletedmaybe_proactive_compressnow loadscompression_guidelinesfrom SQLite and passes them to the summarization view, matching the reactive path; Closes maybe_proactive_compress does not populate compression_guidelines in ContextSummarizationView #3533start_eviction_loopacceptsOption<Arc<EmbeddingStore>>; vectors are deleted before rows are marked clean (crash-safe);runner.rsthreads the embedding store throughSubagentManager::spawn_subagent— replaced with accurate map of three existing enforcement sitesTest plan
cargo nextest run --workspace --lib --bins— 8661 passed, 0 failurescargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— cleancompression_guidelines_flow_through_proactive_compress_pathverifies full SQLite → load → view → LLM-prompt data-flow for maybe_proactive_compress does not populate compression_guidelines in ContextSummarizationView #3533EmbeddingStore::delete_by_message_idsandrun_eviction_phase2Qdrant-cleanup pathFollow-up issues (non-blocking, filed separately)
delete_by_message_idsIN-clause at ~490 IDs to match phase-1 pattern (SQLite 999-var ceiling)crates/zeph-agent-context/README.mdlines 33 and 64 to remove stalerebuild_system_promptreferences