Skip to content

fix: resolve actionable TODOs — path migration, integration test stubs, deferred qdrant_api_key#3545

Merged
bug-ops merged 3 commits intomainfrom
todo-cleanup
Apr 28, 2026
Merged

fix: resolve actionable TODOs — path migration, integration test stubs, deferred qdrant_api_key#3545
bug-ops merged 3 commits intomainfrom
todo-cleanup

Conversation

@bug-ops
Copy link
Copy Markdown
Owner

@bug-ops bug-ops commented Apr 28, 2026

Summary

Changes

crates/zeph-core/src/agent/tool_execution/native.rs
All 39 super::super:: occurrences replaced with crate::agent:: — purely mechanical, semantically equivalent. Import group re-ordered for rustfmt compliance.

tests/gateway_integration.rs, tests/ingest_integration.rs
todo!() (panic-on-enable) replaced with empty function bodies and comments. Tests remain #[ignore]; no longer panic if --ignored is accidentally lifted.

crates/zeph-memory/src/qdrant_ops.rs
Stale // TODO(#2389) updated to // TODO(critic, #3543) pointing to the correctly scoped tracking issue.

What was NOT included

qdrant_ops.rs api_key wiring (originally TODO 3): descoped to #3543 after critic review identified ~40 callers across 8 crates, doc-test breakage, and required vault + init wizard changes — too large for a cleanup PR.

Verification

  • cargo +nightly fmt --check — clean
  • cargo clippy --workspace -- -D warnings — 0 warnings
  • cargo nextest run --workspace --lib --bins — 8673 passed, 21 skipped
  • Both integration stubs now PASS as no-ops under --ignored

bug-ops added 3 commits April 28, 2026 13:00
…ent::* in tool_execution/native.rs; defer qdrant_api_key wiring to #3543
The placeholder comment incorrectly cited #1026 (gateway webhook) instead
of #1028 (document ingestion pipeline).
@github-actions github-actions Bot added memory zeph-memory crate (SQLite) rust Rust code changes core zeph-core crate tests Test-related changes bug Something isn't working size/M Medium PR (51-200 lines) labels Apr 28, 2026
@bug-ops bug-ops merged commit 0c53753 into main Apr 28, 2026
32 checks passed
@bug-ops bug-ops deleted the todo-cleanup branch April 28, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core zeph-core crate memory zeph-memory crate (SQLite) rust Rust code changes size/M Medium PR (51-200 lines) tests Test-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant