fix: resolve actionable TODOs — path migration, integration test stubs, deferred qdrant_api_key#3545
Merged
fix: resolve actionable TODOs — path migration, integration test stubs, deferred qdrant_api_key#3545
Conversation
…ent::* in tool_execution/native.rs; defer qdrant_api_key wiring to #3543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super::super::path references tocrate::agent::inzeph-core/src/agent/tool_execution/native.rs(follow-up to refactor(core): Phase 1 file splits and test extraction in zeph-core #3497)todo!()panics in ignored integration test stubs with empty no-op bodies and explanatory commentsqdrant_ops.rsto reference open tracking issue wire optional Qdrant API key end-to-end #3543Changes
crates/zeph-core/src/agent/tool_execution/native.rsAll 39
super::super::occurrences replaced withcrate::agent::— purely mechanical, semantically equivalent. Import group re-ordered for rustfmt compliance.tests/gateway_integration.rs,tests/ingest_integration.rstodo!()(panic-on-enable) replaced with empty function bodies and comments. Tests remain#[ignore]; no longer panic if--ignoredis accidentally lifted.crates/zeph-memory/src/qdrant_ops.rsStale
// TODO(#2389)updated to// TODO(critic, #3543)pointing to the correctly scoped tracking issue.What was NOT included
qdrant_ops.rsapi_key wiring (originally TODO 3): descoped to #3543 after critic review identified ~40 callers across 8 crates, doc-test breakage, and required vault + init wizard changes — too large for a cleanup PR.Verification
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— 0 warningscargo nextest run --workspace --lib --bins— 8673 passed, 21 skipped--ignored