refactor(common,memory,tui): deduplicate token format helpers and add tracing spans#4364
Merged
Conversation
github-actions
Bot
added
refactor
github-actions
Bot
added
memory
… tracing spans Extract format_tokens(n: u64) -> String into zeph-common/src/text.rs, replacing three identical local implementations in fleet.rs, status.rs, and agents.rs. Closes #4359. Add #[tracing::instrument] to reconcile_stale_sessions and update_agent_session_status in agent_sessions.rs, matching the convention established by upsert_agent_session. Closes #4348.
bug-ops
force-pushed
the
tracing-spans-token-fmt
branch
from
01a2c6f to
eb54e4f
Compare
bug-ops
added a commit
that referenced
this pull request
May 18, 2026
… tracing spans (#4364) Extract format_tokens(n: u64) -> String into zeph-common/src/text.rs, replacing three identical local implementations in fleet.rs, status.rs, and agents.rs. Closes #4359. Add #[tracing::instrument] to reconcile_stale_sessions and update_agent_session_status in agent_sessions.rs, matching the convention established by upsert_agent_session. Closes #4348.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_tokens(n: u64) -> Stringintozeph-common/src/text.rs, replacing three identical local helpers (format_tokens_shortinfleet.rs,format_tokensinstatus.rs,fmt_tokensinagents.rs). All three implemented the same>=1M → X.XM / >=1k → X.Xk / else npattern.#[tracing::instrument(name = "memory.fleet.*", skip_all, level = "debug", err)]toreconcile_stale_sessionsandupdate_agent_session_statusinagent_sessions.rs, matching the existing convention ofupsert_agent_session.Closes #4348
Closes #4359
Test plan
cargo nextest run --workspace --lib --bins— 9879 passed, 0 failedcargo test --doc --workspace --features "desktop,ide,server,chat,pdf,scheduler"— all doc-tests passcargo +nightly fmt --check— cleanRUSTFLAGS="-D warnings" cargo check --workspace --all-targets --features desktop,ide,server,chat,pdf,scheduler --locked— 0 warnings