refactor: remove 8 lightweight feature gates, make always-on (M26)#438
Merged
refactor: remove 8 lightweight feature gates, make always-on (M26)#438
Conversation
github-actions
bot
added
llm
Remove feature gates for openai, compatible, orchestrator, router, self-learning, qdrant, vault-age, and mcp. These features added conditional compilation complexity without significant dependency savings — qdrant-client was already unconditional via zeph-memory, rmcp is lightweight, and the rest were code-only modules. Collapse 3-way tool_executor construction in main.rs into a single block. Remove duplicate ToolExecutorBundleNoMcp and build_tool_executor impl from bootstrap.rs. Clean up ~90 cfg annotations across 5 crates. default features reduced to [] (empty). Remaining gated features: tui, candle, metal, cuda, discord, slack, a2a, index, gateway, daemon, scheduler, otel, mock. 22 files changed, -346/+73 lines. All 1483 tests pass. Closes #436
bug-ops
force-pushed
the
feat/m26/simplify-feature-gates
branch
from
218e4e2 to
34158a3
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai,compatible,orchestrator,router,self-learning,qdrant,vault-age,mcp— make these always-ontool_executorconstruction inmain.rsinto a single blockToolExecutorBundleNoMcpandbuild_tool_executorimpl frombootstrap.rscfgannotations across 5 crates (zeph-llm, zeph-skills, zeph-mcp, zeph-core, root)deny.tomlto remove reference to deleted feature#[cfg(feature = "self-learning")]from test module22 files changed, 73 insertions(+), 346 deletions(-)
Default features reduced to
[]. Remaining gated:tui,candle,metal,cuda,discord,slack,a2a,index,gateway,daemon,scheduler,otel,mock.Test plan
cargo clippy --workspace -- -D warningscargo clippy --workspace --features tui -- -D warningscargo nextest run --workspace --lib --bins(1483 passed)Closes #436