fix(memory): correct ephemeral message in bare mode and deduplicate audit types#4399
Merged
Conversation
github-actions
Bot
added
bug
bug-ops
force-pushed
the
4394-4395-bare-mode-audit-dedup
branch
from
975f1d9 to
066225d
Compare
…udit types In --bare mode, memory_save now returns an ephemeral disclaimer instead of the persistent-mode message that implied data would survive the session. Adds `ephemeral: bool` field to MemoryToolExecutor with a builder, wired from runner.rs when exec_mode.bare is set. Closes #4394. Moves canonical AuditSignalType, Severity, and AuditSignal from zeph-sanitizer and zeph-memory into zeph-common::audit. Both crates re-export the types for backward compatibility, eliminating the manual conversion match arms that the duplication required. Closes #4395.
bug-ops
force-pushed
the
4394-4395-bare-mode-audit-dedup
branch
from
066225d to
b7cb4a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_savein--baremode now returns "Saved to session memory (ephemeral — not available after session ends)." instead of the persistent-mode message that incorrectly implied data would survive the session. Addedephemeral: boolfield with a#[must_use]builder toMemoryToolExecutor; wired fromrunner.rswhenexec_mode.bareis set.AuditSignalType,Severity, andAuditSignalfromzeph-sanitizerandzeph-memoryintozeph-common::audit. Both crates re-export the types for backward compatibility, eliminating duplicate definitions and the manual conversion match arms they required.Closes #4394
Closes #4395
Test plan
cargo nextest run --workspace --lib --bins— 9905 passed, 21 skippedmemory_save_ephemeral_returns_session_only_messagecovers the ephemeral branchcargo test --doc --workspace --features "desktop,ide,server,chat,pdf,scheduler"cargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— clean