spec(skills): GoSkills group-structured retrieval — RFC #4219#4410
Merged
Conversation
github-actions
Bot
added
size/M
9 tasks
bug-ops
force-pushed
the
feat/issue-4219/rfc-skill-structure
branch
from
5345a00 to
3c322de
Compare
Extends specs/005-skills/spec.md with group-structured skill retrieval (RFC #4219). After hybrid BM25+embedding matching, compute inter-skill cosine similarity on top-N candidates; if similarity >= threshold, present to LLM as structured group (entry-point + support + requirements + failure-avoidance). Falls back to flat injection when skills are unrelated. Key decisions: - Opt-in via skills.group_structured = false default - Threshold on inter-skill cosine similarity, not RRF-fused scores - SkillOrchestra bandit operates on individual skills; grouping is post-selection presentation only - trust/sanitization/quarantine logic preserved per-skill within groups - A/B validation via zeph-experiments required before enabling default Appends RFC #4219 comparison matrix covering all 8 evaluated approaches with rejection rationale. Closes #4000, #4064, #4065, #4090, #4091, #4125, #4166, #4195, #4219
bug-ops
force-pushed
the
feat/issue-4219/rfc-skill-structure
branch
from
3c322de to
6915acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves RFC #4219 by extending
/specs/005-skills/spec.mdwith GoSkills group-structured skill retrieval.After evaluating all 8 research proposals consolidated in #4219, GoSkills (#4091) was selected as the only approach that fills a genuine gap in the current flat registry without adding storage complexity or LLM inference loops.
Changes
specs/005-skills/spec.md— new section "Group-Structured Retrieval (GoSkills)" + "Appendix: RFC RFC: skill structure beyond flat registry (hierarchy, graph, groups) #4219 Comparison Matrix"Design
Post-selection presentation layer: after BM25+embedding hybrid matching produces top-N candidates, compute inter-skill cosine similarity. If similarity ≥
support_similarity_threshold(default 0.50), inject skills as a structured group (entry-point + support + requirements + failure-avoidance). Otherwise falls back to existing flat injection.Key invariants:
skills.group_structured = falsedefaultCloses
Closes #4219, #4091, #4000, #4064, #4065, #4090, #4125, #4166, #4195