fix(runner): restore five_signal_metrics in spawn_metrics_sync_with_five_signal#4434
Merged
Merged
Conversation
github-actions
Bot
added
bug
bug-ops
force-pushed
the
4427-five-signal-prometheus-metrics
branch
from
7b88e44 to
fb5e498
Compare
…ive_signal Commit 2a105e9 accidentally replaced the five_signal_metrics derivation with None, silently disabling all four five_signal Prometheus counters. Restore memory.five_signal_runtime().map(|rt| Arc::clone(&rt.metrics)) and pass it to spawn_metrics_sync_with_five_signal. Add regression test test_spawn_metrics_sync_receives_five_signal to src/metrics_export.rs to guard against recurrence. Closes #4427
bug-ops
force-pushed
the
4427-five-signal-prometheus-metrics
branch
from
fb5e498 to
46c1474
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonetospawn_metrics_sync_with_five_signal, silently disabling the four five_signal Prometheus counters (zeph_five_signal_recall_total,zeph_five_signal_consolidation_*).memory.five_signal_runtime().map(|rt| Arc::clone(&rt.metrics))and passes it instead ofNone.test_spawn_metrics_sync_receives_five_signalinsrc/metrics_export.rs.Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— cleancargo nextest run --workspace --lib --bins— 9969 passed, 21 skippedCloses #4427