fix(acp): wire IDE-provided MCP servers into do_new_session#4444
Merged
Conversation
github-actions
Bot
added
bug
bug-ops
force-pushed
the
4442-acp-mcp-servers-wiring
branch
from
b0919e5 to
5110dca
Compare
acp_mcp_servers_to_entries was implemented and exported but never called. do_new_session now converts NewSessionRequest.mcp_servers and registers each ServerEntry with McpManager before the first prompt arrives. Per-server registration failures are logged as warnings so session creation is never interrupted. Also re-enables 11 unit tests in mcp_bridge.rs that were left under acp::McpServer* to acp::schema::McpServer* to match the new re-export structure. Closes #4442
bug-ops
force-pushed
the
4442-acp-mcp-servers-wiring
branch
from
5110dca to
4c0029a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
do_new_sessionnow callsacp_mcp_servers_to_entries(&args.mcp_servers)and registers eachServerEntrywithMcpManagerbefore the first prompt arriveswarn!— session creation is never interruptedmcp_bridge.rs(were under#[cfg(any())]since ACP 0.10 migration); updated type paths toacp::schema::McpServer*for ACP 0.11 compatibilityTest plan
cargo build --features acp— passescargo clippy --workspace -- -D warnings— passescargo +nightly fmt --check— passescargo nextest run -p zeph-acp— 65 tests pass (includes 11 re-enabled mcp_bridge tests)Closes #4442