feat(acp): upgrade agent-client-protocol to 0.12.1 and add standard session/delete#4464
Merged
Conversation
…lete Closes #4454, Closes #4458 - Bump agent-client-protocol 0.11.1 → 0.12.1 in workspace Cargo.toml; agent-client-protocol-tokio stays at 0.11.1 (no 0.12.x published yet) - Migrate feature gate unstable-session-close → unstable-session-delete across Cargo.toml, lib.rs, and all cfg(feature) guards in zeph-acp - Add standard session/delete handler (delete_session.rs) under unstable-session-delete feature gate using SDK DeleteSessionRequest/Response - Register session/delete in run_agent() alongside the existing ext method - Deprecate _session/delete ext method: emit tracing::warn! on each call
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-client-protocolfrom0.11.1to0.12.1;agent-client-protocol-tokiostays at0.11.1(no 0.12.x release published yet)unstable-session-close→unstable-session-deleteacrossCargo.toml,lib.rs, and allcfg(feature)guards inzeph-acpsession/deletehandler (delete_session.rs) under theunstable-session-deletefeature gate using the SDK'sDeleteSessionRequest/DeleteSessionResponsetypes_session/deleteext method with atracing::warn!deprecation noticeBreaking changes
None for downstream consumers. The feature gate rename (
unstable-session-close→unstable-session-delete) only affectszeph-acpinternal feature composition.Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— cleancargo nextest run --workspace --lib --bins— 10003 passed, 0 failedcargo deny check advisories— only pre-existing RUSTSEC-2025-0134 (tracked in dep: rustls-pemfile 2.2.0 unmaintained (RUSTSEC-2025-0134) — migrate to rustls-pki-types #3772), nothing new from this bumpsession/deletecovered by 3 tests intransport/crud.rs_session/deletedeprecation covered by 4 tests incustom.rsCloses #4454
Closes #4458