feat(acp): implement Providers API and Elicitation protocol#4473
Merged
Conversation
github-actions
Bot
added
enhancement
Add ACP schema 0.13.2 Providers API (providers/list, providers/set, providers/disable) as session-scoped overrides that do not persist after session/close. Vault-resolved API keys are never exposed in responses. Add Elicitation protocol infrastructure: elicitation/create request and response flow via per-session bridge task with cancel-signal awareness. The agent loop integration (calling elicit() from tier_loop) is tracked separately in follow-up issues. Replace hardcoded 120s timeouts in terminal.rs and mcp_bridge.rs with configurable [acp.timeouts] section (elicitation_secs, terminal_secs, mcp_secs). Add agent-client-protocol-schema = "0.13.2" as direct workspace dep to gate unstable-elicitation and unstable-llm-providers features. Closes #4456 Closes #4455
bug-ops
force-pushed
the
acp-elicitation-providers
branch
from
d38c423 to
0bc9a97
Compare
…nitializations Wire AcpTimeoutsConfig into the stdio and HTTP ACP server config builders in src/acp.rs. Fixes MSRV check failure (E0063: missing field timeouts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers/list,providers/set,providers/disable) as session-scoped overrides — no vault keys exposed in responses, no persistent config mutationelicitation/create→elicitation/responseflow via per-session bridge task with cancel-signal awareness and configurable timeoutterminal.rsandmcp_bridge.rswith configurable[acp.timeouts]config sectionagent-client-protocol-schema = "0.13.2"as direct workspace dep forunstable-elicitationandunstable-llm-providersfeature gatesWhat is NOT in this PR
elicit()fromtier_loop(follow-up PR)Security
providers/listresponse contains onlyapi_type+base_url— vault-resolved API keys are never serializedproviders/setvalidatesreq.idagainst known provider names before inserting into override map (SEC-1 fix)Test plan
cargo build -p zeph-acp --features "unstable-elicitation,unstable-llm-providers"— cleancargo clippy --workspace -- -D warnings— 0 warningscargo nextest run --workspace --lib --bins— 10019 passedzeph-acpincluding 8 providers tests and 6 elicitation timeout testsCloses #4456
Closes #4455