fix(sanitizer): add wildcard arms to non-exhaustive InjectionEnforcementMode match#4562
Merged
Conversation
…entMode match InjectionEnforcementMode is #[non_exhaustive] in zeph-config; match expressions in regex_verdict and binary_score_to_verdict lacked wildcard arms, causing E0004 when compiling zeph-sanitizer with --features classifiers. Replace explicit Warn/_ duplicate pattern with a single _ => Suspicious arm in both match sites. Closes #4557
github-actions
Bot
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InjectionEnforcementModeinzeph-configis#[non_exhaustive], requiring a wildcard arm in all external match expressionscrates/zeph-sanitizer/src/sanitizer.rs(regex_verdict,binary_score_to_verdict) lacked_arms, causingE0004when building with--features classifiersWarn => Suspicious+_ => Suspiciousduplicate pattern with a single_ => Suspiciousarm in both sitesTest plan
cargo build -p zeph-sanitizer --features classifiers,zeph-memory/sqlite—Finishedwith no errorscargo clippy -p zeph-sanitizer --features classifiers,zeph-memory/sqlite -- -D warnings— cleancargo nextest run -p zeph-sanitizer --features classifiers,zeph-memory/sqlite— 343 passed, 2 skippedcargo +nightly fmt --check— cleanCloses #4557