feat(worktree): make DefaultGitRunner timeout configurable via WorktreeConfig#4784
Merged
Conversation
github-actions
Bot
added
documentation
…eeConfig Add `git_timeout_secs: u64` (default 30) to `WorktreeConfig`. Both `DefaultGitRunner` construction sites now use this value via `.max(1)` clamp to prevent zero-duration timeouts. Migration step 55 injects the commented field into existing `[worktree]` config sections. Closes #4704
bug-ops
force-pushed
the
worktree-git-timeout
branch
from
7e18e6c to
603dcd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_timeout_secs: u64(default30) toWorktreeConfiginzeph-configDefaultGitRunnerconstruction sites (src/runner.rs,src/commands/worktree.rs) now passDuration::from_secs(config.worktree.git_timeout_secs.max(1))instead of a hardcoded 30 s# git_timeout_secs = 30into existing[worktree]sections that lack the keyTest plan
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— 0 warningscargo nextest run --workspace --lib --bins— 10456 passedWorktreeConfigfield (default, serde round-trip, custom value, missing key)Closes #4704