refactor(tracing): add #[tracing::instrument] to channels, orchestration, and llm hot paths#4833
Merged
Conversation
github-actions
Bot
added
documentation
…ion, and llm hot paths Instruments 17 uninstrumented async fns in zeph-channels under the `profiling` feature gate (channel.<adapter>.<operation> naming), PlanCache::find_similar and cache_plan in zeph-orchestration (plain instrument, no profiling feature in that crate), and OllamaProvider::chat_with_tools in zeph-llm (cfg_attr profiling), completing profiling coverage across all LlmProvider backends. Closes #4818, #4807, #4824
bug-ops
force-pushed
the
tracing-instrument
branch
from
240bb58 to
0b87950
Compare
This was
linked to
issues
Jun 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeph-channels(Telegram API ext, Discord REST client, Slack API client) under#[cfg_attr(feature = "profiling", tracing::instrument(name = "channel.<adapter>.<op>", skip_all))]PlanCache::find_similarandPlanCache::cache_planspans inzeph-orchestration(plain#[tracing::instrument]— orchestration crate has noprofilingfeature)OllamaProvider::chat_with_toolsinstrumentation inzeph-llm, completing profiling coverage across all fiveLlmProviderbackendsTest plan
cargo nextest run --workspace --lib --bins— 10496/10496 passed (verified in CI)cargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— cleangit diff origin/main --name-only— exactly 7 files (6 source + CHANGELOG).entered()across.awaitin any modified fileCloses #4818, #4807, #4824