Use std::tmpfile in create_file on Windows#215
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
A Windows-specific refactor to use std::tmpfile for temporary file creation and then reopen it with the requested mode, removing manual signal/permission handling.
- Introduce a
create_file(mode, ec)overload that delegates tostd::tmpfileand uses Windows APIs to recover the file path and reopen it. - Simplify the existing
create_file(mode)on Windows to call the new overload and convert errors tostd::filesystem_error. - Update tests to drop the hardlink count assertion under the Windows branch.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/file.cpp | Removed the hardlink-count check from the Windows test path. |
| src/create.cpp | Added _CRT_SECURE_NO_WARNINGS, included platform headers, and implemented the std::tmpfile–based create_file. |
Comments suppressed due to low confidence (1)
tests/file.cpp:77
- [nitpick] The hardlink-count assertion was removed from the Windows test path, potentially reducing coverage of link-related behavior. If ensuring no hardlinks is still important, consider adding a Windows-specific check or replacing this assertion with an equivalent check.
EXPECT_EQ(file_info.nNumberOfLinks, 0); // Has no hardlinks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of dealing with signals, file permissions and such, delegate it to
std::tmpfileAfter creating the file, we can simply
std::freopenthe file with the desiredopenmodePart of #193 for Windows