[Enhancement] Get file volume component #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the quality is set 4, due to this bit rate is not set properly.
By default the quality is set 4, due to this bit rate is not set properly.
Correct audio codecs were never applied. For example, AudioFormat_Mkv sets audioCodec to libvorbis, but instead, setAudioCodec function instead sets codec as vorbis. Found the bug when working with mono files.
Corrected typo
Added getFileVolumeComponent() function and relevant code to get mean and max volume of file.
Added function readVolumeComponent() to read volume component.
Corrected typo
Volume can end in 'dB', and can be float as well as integer.
SamarRizvi
changed the title
Corrected typo
No mean and max volume components were returned for linux systems. Now, it works fine.
Fixed bug when Ffmpeg returns error **No such filter: '"volume'** on many systems due volume being enclosed in inverted commas.
if volume ends with 'db' change it to 'dB', else ffmpeg may produce error in some cases.
Update ExecBuffer.php
Update AudioFormat.php
Major bugfix (correct codecs never applied)
Set bitrate properly
buggedcom
added a commit
that referenced
this pull request
Feb 9, 2016
[Enhancement] Get file volume component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to get file volume component (mean and max volume). It eases the task of setting / normalizing volume, since this way, user already knows the max volume of the input file.