Merged
Conversation
Ignore CMakeLists.txt.user file
Backtrace:
LVStyleSheet::apply(ldomNode const *, css_style_rec_tag *) 0x55555567bc28
setNodeStyle(ldomNode *, LVFastRef<css_style_rec_tag>, LVProtectedFastRef<LVFont>) 0x5555556d2d23
ldomNode::initNodeStyle() 0x555555640954
updateStyleDataRecursive(ldomNode *) 0x555555640e50
updateStyleDataRecursive(ldomNode *) 0x555555640ef0
updateStyleDataRecursive(ldomNode *) 0x555555640ef0
updateStyleDataRecursive(ldomNode *) 0x555555640ef0
ldomDocument::render(LVRendPageList *, LVDocViewCallback *, int, int, bool, int, LVProtectedFastRef<LVFont>, int, LVFastRef<CRPropAccessor>) 0x555555646771
LVDocView::Render(int, int, LVRendPageList *) 0x5555556ae862
LVDocView::checkRender() 0x5555556aea50
LVDocView::updateBookMarksRanges() 0x5555556b2fa6
LVDocView::propsApply(LVFastRef<CRPropAccessor>) 0x5555556c7815
CR3View::loadSettings(QString) 0x5555555ce64e
MainWindow::MainWindow(QWidget *) 0x5555555da585
main 0x5555555b928c
|
Also see koreader/crengine#90 (comment)
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug with wrong value in the "Page Skin" combo box ("Settings => Style" dialog).
Steps to reproduce:
1.1. Run new and clear instance of the Cool Reader, go to the "Settings => Style => Page Skin".
1.2. It shows bg_paperX (instead of [NONE]).
1.3. Choose second (after [NONE]) page skin, click "OK".
1.4. Nothing will change.
Fix compilation error on the new GCC versions: