Skip to content

Select support uda#92

Closed
shoo wants to merge 3 commits intobuggins:masterfrom
shoo:select_support_uda
Closed

Select support uda#92
shoo wants to merge 3 commits intobuggins:masterfrom
shoo:select_support_uda

Conversation

@shoo
Copy link
Contributor

@shoo shoo commented Jul 25, 2020

The ddbc.pods are very friendly to UDA. So I let the UDA be applied to select.

As an addendum, I thought about refactoring the part of the commit that was too cluttered following this one and making UDA support for insert/update/remove as well. However, the commit was huge enough by the time I got it to support select, so I decided to split it up. If this pull request is accepted, I'll post the rest of the split in order.

After all the changes are made, it looks like this:
https://github.com/shoo/ddbc/blob/c25eb0f034d6a6a03c1f1050d7fdd84677c0ab1d/source/ddbc/pods.d

@shoo shoo force-pushed the select_support_uda branch from 07a878d to 898e963 Compare July 25, 2020 09:20
@SingingBush
Copy link
Collaborator

There's good stuff in this PR, it just needs to be in the right place and be consistent with existing approach.

The pod stuff should arguably not be in ddbc or if it does, it should at least be another module. So we end up with something like:

  • ddbc-core
  • ddbc-uda

This kind of thing is covered by Hibernated specifically in the annotations.d code with things like @Entity, @Table("table_name"), and @Column("column_name")

@shoo
Copy link
Contributor Author

shoo commented Feb 5, 2021

I see. I close this PR here.
I am embarrassed to say that I only knew Hibernated by name, so I would like to learn it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants