Conversation
Collaborator
|
There's good stuff in this PR, it just needs to be in the right place and be consistent with existing approach. The pod stuff should arguably not be in ddbc or if it does, it should at least be another module. So we end up with something like:
This kind of thing is covered by Hibernated specifically in the annotations.d code with things like |
Contributor
Author
|
I see. I close this PR here. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ddbc.pods are very friendly to UDA. So I let the UDA be applied to
select.As an addendum, I thought about refactoring the part of the commit that was too cluttered following this one and making UDA support for insert/update/remove as well. However, the commit was huge enough by the time I got it to support select, so I decided to split it up. If this pull request is accepted, I'll post the rest of the split in order.
After all the changes are made, it looks like this:
https://github.com/shoo/ddbc/blob/c25eb0f034d6a6a03c1f1050d7fdd84677c0ab1d/source/ddbc/pods.d