fix: XHProf profiler endpoint always detected as Sentry#328
Merged
butschster merged 2 commits intobuggregator:masterfrom Apr 9, 2026
Merged
fix: XHProf profiler endpoint always detected as Sentry#328butschster merged 2 commits intobuggregator:masterfrom
butschster merged 2 commits intobuggregator:masterfrom
Conversation
butschster
added a commit
that referenced
this pull request
Apr 9, 2026
After PR #328 moved storeProfile from Handle() to OnEventStored(), the MCP test's ingestViaHandler helper no longer populated profiler-specific tables. Add the missing NotifyEventStored call to match the real HTTP server flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/profiler/storebeing intercepted by the Sentry handler (priority 10) before the Profiler handler (priority 40)storeProfileout ofHandle()intoOnEventStored()Root causes
1. Double interception of
/profiler/storedetect.goauto-detected any path ending in/storeas Sentry, andsentry/handler.goMatch() also matched/storeindependently. Both now exclude paths containing/profiler/.2. SQLite contention /
context canceledprofiler/handler.gowas callingstoreProfile()insideHandle(), then the pipeline calledeventService.Store()— two concurrent writes on aMaxOpenConns(1)connection caused the HTTP context to expire. Moved toOnEventStored().3. Flamechart stack overflow
buildNodeinapi.gohad no cycle detection. Added avisitedmap to break cycles.Test plan
POST /api/profiler/storestores astype=profiler/api/1/storestill workgo test ./internal/server/http/passes