This repository was archived by the owner on Jan 7, 2021. It is now read-only.
Upgrade node-expat to 2.1.4#49
Merged
c4milo merged 1 commit intobuglabs:masterfrom Feb 10, 2014
maherbeg:master
Merged
Conversation
This will allow compiling xml2json on newer versions of Node, such as v0.11.x and above.
|
Sweet, this worked for me. Any chance you can bump and push to npm? |
Contributor
|
I just published version 0.4.0 which includes this PR as well as some others. I would suggest testing thoroughly before upgrading production systems. |
|
Thanks! I'll give it a shot and let you know if we run into problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow compiling xml2json on newer versions of Node, such as v0.11.x and above.
I ran the existing tests and they all pass.