Skip to content
This repository was archived by the owner on Jan 7, 2021. It is now read-only.

Upgrade node-expat to 2.1.4#49

Merged
c4milo merged 1 commit intobuglabs:masterfrom
maherbeg:master
Feb 10, 2014
Merged

Upgrade node-expat to 2.1.4#49
c4milo merged 1 commit intobuglabs:masterfrom
maherbeg:master

Conversation

@maherbeg
Copy link
Copy Markdown
Contributor

This will allow compiling xml2json on newer versions of Node, such as v0.11.x and above.

I ran the existing tests and they all pass.

[xml2json: array-notation.xml->array-notation.json] passed!
[xml2json: coerce.xml->coerce.json] passed!
[json2xml: domain-reversible.json->domain.xml] passed!
[xml2json: domain.xml->domain.json] passed!
[xml2json: large.xml->large.json] passed!
[xml2json: reorder.xml->reorder.json] passed!
[xml2json: spacetext.xml->spacetext.json] passed!

This will allow compiling xml2json on newer versions of Node,
such as v0.11.x and above.
c4milo added a commit that referenced this pull request Feb 10, 2014
Upgrade node-expat to 2.1.4
@c4milo c4milo merged commit 8aacd58 into buglabs:master Feb 10, 2014
@calvinfo
Copy link
Copy Markdown

Sweet, this worked for me. Any chance you can bump and push to npm?

@c4milo
Copy link
Copy Markdown
Contributor

c4milo commented Feb 13, 2014

I just published version 0.4.0 which includes this PR as well as some others. I would suggest testing thoroughly before upgrading production systems.

@calvinfo
Copy link
Copy Markdown

Thanks! I'll give it a shot and let you know if we run into problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants