Add optional parameter for get /groups ?include_metrics#39
Merged
Andrei-Dolgolev merged 2 commits intomainfrom Aug 17, 2022
Merged
Add optional parameter for get /groups ?include_metrics#39Andrei-Dolgolev merged 2 commits intomainfrom
Andrei-Dolgolev merged 2 commits intomainfrom
Conversation
added 2 commits
August 17, 2022 19:39
default is true If true: collect num of users and num of seats in each group. False return just list of user group without additional queries.
zomglings
reviewed
Aug 17, 2022
| num_seats = get_num_seats(session, group) | ||
|
|
||
| groups_response.append( | ||
| data.GroupUserResponse( |
Member
There was a problem hiding this comment.
@Andrei-Dolgolev : Do you have to change Pydantic model to make num_users and num_seats Optional?
Contributor
Author
There was a problem hiding this comment.
Already Optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default is true
If true: collect num of users and num of seats in each group.
False return just list of user group without additional queries.
Changes
How to test these changes?
Related issues