Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

Removing setERC20Metadata function and adding it to Initializer#45

Merged
zomglings merged 2 commits intobugout-dev:mainfrom
uchami-lg:set-erc20-metadata-on-initialize
May 16, 2022
Merged

Removing setERC20Metadata function and adding it to Initializer#45
zomglings merged 2 commits intobugout-dev:mainfrom
uchami-lg:set-erc20-metadata-on-initialize

Conversation

@uchami-lg
Copy link
Copy Markdown
Contributor

Changes

In order to be compliant with exchanges we need symbol and name to be fixed. So that's why instead of having a default symbol MNSTR and name Moonstream DAO. The values are provided to the initializer to do that an optional parameter initializer_params was added to the facet_cut function.

How to test these changes?

test_moonstream has been modified in order to check that everything is working properly.

Copy link
Copy Markdown
Contributor

@Yhtiyar Yhtiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zomglings
Copy link
Copy Markdown
Member

@uchami-lg : Can you please run black formatting on this code?

black dao/

and then commit and push.

@zomglings zomglings merged commit d6e089d into bugout-dev:main May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants