This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Conversation
Member
|
@bugout-dev check
|
zomglings
approved these changes
Jul 6, 2022
Member
zomglings
left a comment
zomglings
left a comment
There was a problem hiding this comment.
gg
Ran tests and tests passing.
| ) | ||
|
|
||
| final_pool_supply = self.diamond_terminus.terminus_pool_supply(pool_id) | ||
| self.assertEqual(final_pool_supply, initial_pool_supply + num_accounts) |
Member
There was a problem hiding this comment.
initial_pool_supply + sum(target_amounts) would be a better implementation here.
| self.diamond_terminus.approve_for_pool( | ||
| pool_id, accounts[3], {"from": accounts[1]} | ||
| ) | ||
| with self.assertRaises(Exception): |
Member
There was a problem hiding this comment.
Tests for unapproved operators are doing as part of the approval tests. This is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test these changes?
Now
approveForPoolgrants minting permissionRelated issues