Skip to content

Fix search endpoint#52

Merged
Andrei-Dolgolev merged 5 commits intomainfrom
fix-search-endpoint
Aug 18, 2022
Merged

Fix search endpoint#52
Andrei-Dolgolev merged 5 commits intomainfrom
fix-search-endpoint

Conversation

@Andrei-Dolgolev
Copy link
Copy Markdown
Contributor

Changes

How to test these changes?

Related issues

Comment thread spire/journal/actions.py
db_session.query(JournalEntry)
.filter(JournalEntry.id == journal_entry_id)
.one_or_none()
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> JournalEntry: to -> Optional[JournalEntry]:

Copy link
Copy Markdown
Collaborator

@kompotkot kompotkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@Andrei-Dolgolev Andrei-Dolgolev merged commit 44b6dfc into main Aug 18, 2022
@kompotkot kompotkot deleted the fix-search-endpoint branch August 18, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants