Conversation
Collaborator
Author
|
@bugout-dev check
|
zomglings
approved these changes
Sep 1, 2022
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.add_column('journal_entries', sa.Column('locked_by', sa.String(), nullable=True)) | ||
| op.create_index(op.f('ix_journal_entries_locked_by'), 'journal_entries', ['locked_by'], unique=False) | ||
| op.create_unique_constraint('uq_journal_entries_id_locked_by', 'journal_entries', ['id', 'locked_by']) |
Member
There was a problem hiding this comment.
id is primary key so it's already unique. This constraint doesn't add anything.
Member
|
Migration was taking a long time because of index creation. We cancelled the migration for now. Need to update implementation so that we store a separate table with current locks. |
zomglings
approved these changes
Sep 5, 2022
| ) | ||
|
|
||
|
|
||
| @app.delete( |
Member
There was a problem hiding this comment.
Might be a good idea to make an explicit CREATE endpoint here, as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Design doc: https://docs.google.com/document/d/1kA57f-Xn06VMicesQ1DB56RekbAgKIQd0DcBI2UHQL0/edit#
How to test these changes?
Tested locally
Related issues