fix(ci): unbreak linux package build and stabilize ios bridge snapshot#59
Merged
fix(ci): unbreak linux package build and stabilize ios bridge snapshot#59
Conversation
- bin.js: guard the dist.cmake write with `existsSync(prebuilt)`. On
non-darwin runners createLib + createXCFramework early-return for ios
targets, so `<output>/prebuilt/` never exists; the template write was
crashing with ENOENT and failing `cppjs build -p ios` on linux CI.
When prebuilt artifacts are absent the template is meaningless, so
silently skip.
- ci snapshot: rename
cppjs-sample-mobile-reactnative-cli/ci/.cppjs/...
->
cppjs-sample-mobile-reactnative-cli/ci/cppjs-snapshot/...
so that pnpm clear:cache:samples (and any future variant matching
`**/.cppjs`) cannot accidentally wipe the bridge fixtures used by the
iOS test workflow. Restore the four files that were lost in the
previous deletion.
- test-ios-sample.yml: copy snapshot contents into the sample's `.cppjs/`
using `mkdir -p` + trailing `/.` so the restore never nests
`cppjs-snapshot/` inside `.cppjs/` regardless of pre-existing state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin.js: guard the dist.cmake write with
existsSync(prebuilt). On non-darwin runners createLib + createXCFramework early-return for ios targets, so<output>/prebuilt/never exists; the template write was crashing with ENOENT and failingcppjs build -p ioson linux CI. When prebuilt artifacts are absent the template is meaningless, so silently skip.ci snapshot: rename cppjs-sample-mobile-reactnative-cli/ci/.cppjs/... -> cppjs-sample-mobile-reactnative-cli/ci/cppjs-snapshot/... so that pnpm clear:cache:samples (and any future variant matching
**/.cppjs) cannot accidentally wipe the bridge fixtures used by the iOS test workflow. Restore the four files that were lost in the previous deletion.test-ios-sample.yml: copy snapshot contents into the sample's
.cppjs/usingmkdir -p+ trailing/.so the restore never nestscppjs-snapshot/inside.cppjs/regardless of pre-existing state.