v3.2.1#98
Merged
fractalwrench merged 17 commits intomasterfrom Aug 21, 2018
Merged
Conversation
Fails the build on compiler warnings. Addresses/suppresses existing warnings in code, and disables a warning about the classpath when building for 1.6 sourceCompatibility when using JDK 8
refactor: fail build on compiler warnings
Capture trace of error reporting thread and identify with boolean flag
HttpUrlConnection may be null if the URL is malformed, or if a connection to the host could not be opened. In this case `connection` will be null and no additional cleanup will be required.
fix: add null check when disconnecting HttpUrlConnection
Remove flaky session tracker test which intermittently fails on CI
Make constructors public for SyncHttpDelivery
bengourley
approved these changes
Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changeset for next release