Merged
Conversation
Member
StephenHodgson
commented
Oct 23, 2025
- refactored action to use unity-cli@v1.5.0
- refactored action to use unity-cli@v1.5.0
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the action to use unity-cli@v1.5.0, significantly simplifying the codebase by delegating Unity process management to an external library. The major version bump to v3.0.0 indicates breaking changes in the API.
Key changes:
- Replaced custom Unity process execution and management logic with
@rage-against-the-pixel/unity-clilibrary - Removed extensive custom code for process handling, argument validation, and log tailing
- Updated action version references from v2 to v3 in documentation and workflows
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Refactored to use unity-cli library instead of custom Unity execution logic |
| src/utils.ts | Removed process management utilities, kept only shellSplit function with improved empty string handling |
| src/unity.ts | Deleted entire Unity execution implementation |
| src/types.ts | Deleted type definitions (now provided by unity-cli) |
| src/inputs.ts | Deleted input validation logic (now handled by unity-cli) |
| package.json | Updated to version 3.0.0, replaced action dependencies with unity-cli library |
| README.md | Updated examples to reference v3 and removed unnecessary quotes |
| .github/workflows/validate.yml | Updated checkout action to v5 and added timeline job |
| .github/workflows/update-release-tags.yml | Updated checkout action to v5 |
| .github/workflows/scripts/get-unity-template.sh | Removed template retrieval script (functionality moved elsewhere) |
| .github/workflows/build.yml | Updated to use new unity-setup and create-unity-project actions, removed template script usage |
| .github/workflows/build-options.json | Expanded Unity version coverage and added more build target combinations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.