Skip to content

Update waterfall view#1191

Merged
djmitche merged 1 commit intobuildbot:masterfrom
tothandras:waterfall_view
Aug 3, 2014
Merged

Update waterfall view#1191
djmitche merged 1 commit intobuildbot:masterfrom
tothandras:waterfall_view

Conversation

@tothandras
Copy link
Copy Markdown
Contributor

New features:

  • configurable variables
  • lazy load builds (infinite scroll)
  • stay on left Y (time) axis
  • auto update fix (it should work now)
  • visual distinction for the time ticks
  • support running builds and unfinished steps
  • cache steps
  • clickable builder names

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will reload all data + some more, instead of loading more data, and appending it.

Need to improve the buildbotService so that you can call @builds.more(), that would play with offset and limit of the rest api to get more builds.

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Aug 2, 2014

I think those are good improvements, and should be merged.
There is a need to improve the infinite scrolling, but this can be done later.

@djmitche
Copy link
Copy Markdown
Member

djmitche commented Aug 3, 2014

I'll get it merged! You do have the power to merge, too ;)

@djmitche djmitche merged commit 438dcc8 into buildbot:master Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants